Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin docs to explicitly list python, boto3 and botocore version requirements #819

Conversation

tremble
Copy link
Contributor

@tremble tremble commented May 19, 2022

SUMMARY

Update plugin docs to explicitly list python, boto3 and botocore version requirements in line with collection requirements.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

plugins/inventory/aws_ec2.py
plugins/inventory/aws_rds.py
plugins/lookup/aws_account_attribute.py
plugins/lookup/aws_secret.py
plugins/lookup/aws_ssm.py

ADDITIONAL INFORMATION

This is in line with the collection requirements, just trying to make it easier to find.

@tremble tremble requested a review from alinabuzachis May 19, 2022 12:10
@github-actions
Copy link

github-actions bot commented May 19, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@tremble tremble force-pushed the plugin/boto3/docs branch from f4009f5 to f9703e7 Compare May 19, 2022 12:34
@ansibullbot ansibullbot added the new_plugin New plugin label May 19, 2022
@softwarefactory-project-zuul

This comment was marked as outdated.

…ion requirements in line with collection requirements
@tremble tremble force-pushed the plugin/boto3/docs branch from f9703e7 to add2ec0 Compare May 19, 2022 13:15
Copy link
Collaborator

@alinabuzachis alinabuzachis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 08s
✔️ build-ansible-collection SUCCESS in 5m 09s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 10m 09s
✔️ ansible-test-sanity-aws-ansible-2.9-python38 SUCCESS in 11m 36s
✔️ ansible-test-sanity-aws-ansible-2.11-python38 SUCCESS in 9m 24s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 01s
✔️ ansible-test-splitter SUCCESS in 2m 40s
✔️ integration-amazon.aws-1 SUCCESS in 34m 45s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added backport-2 PR should be backported to the stable-2 branch backport-3 PR should be backported to the stable-3 branch mergeit Merge the PR (SoftwareFactory) labels May 19, 2022
@tremble tremble mentioned this pull request May 19, 2022
1 task
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 10s
✔️ build-ansible-collection SUCCESS in 5m 20s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 9m 45s
✔️ ansible-test-sanity-aws-ansible-2.9-python38 SUCCESS in 9m 56s
✔️ ansible-test-sanity-aws-ansible-2.11-python38 SUCCESS in 10m 30s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 26s
✔️ ansible-test-splitter SUCCESS in 3m 23s
✔️ integration-amazon.aws-1 SUCCESS in 34m 10s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit e919bec into ansible-collections:main May 19, 2022
@patchback

This comment was marked as resolved.

@patchback

This comment was marked as resolved.

tremble added a commit to tremble/amazon.aws that referenced this pull request May 19, 2022
…ion requirements in line with collection requirements (ansible-collections#819)

Update plugin docs to explicitly list python, boto3 and botocore version requirements

SUMMARY
Update plugin docs to explicitly list python, boto3 and botocore version requirements in line with collection requirements.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
plugins/inventory/aws_ec2.py
plugins/inventory/aws_rds.py
plugins/lookup/aws_account_attribute.py
plugins/lookup/aws_secret.py
plugins/lookup/aws_ssm.py
ADDITIONAL INFORMATION
This is in line with the collection requirements, just trying to make it easier to find.

Reviewed-by: Alina Buzachis <None>
tremble added a commit to tremble/amazon.aws that referenced this pull request May 19, 2022
…ion requirements in line with collection requirements (ansible-collections#819)

Update plugin docs to explicitly list python, boto3 and botocore version requirements

SUMMARY
Update plugin docs to explicitly list python, boto3 and botocore version requirements in line with collection requirements.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
plugins/inventory/aws_ec2.py
plugins/inventory/aws_rds.py
plugins/lookup/aws_account_attribute.py
plugins/lookup/aws_secret.py
plugins/lookup/aws_ssm.py
ADDITIONAL INFORMATION
This is in line with the collection requirements, just trying to make it easier to find.

Reviewed-by: Alina Buzachis <None>
softwarefactory-project-zuul bot pushed a commit that referenced this pull request May 19, 2022
…ion requirements in line with collection requirements (#819) (#821)

[stable-3] Update plugin docs to explicitly list python, boto3 and botocore version

Manual backport of #819
SUMMARY
Update plugin docs to explicitly list python, boto3 and botocore version requirements in line with collection requirements.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
plugins/inventory/aws_ec2.py
plugins/inventory/aws_rds.py
plugins/lookup/aws_account_attribute.py
plugins/lookup/aws_secret.py
plugins/lookup/aws_ssm.py
ADDITIONAL INFORMATION
This is in line with the collection requirements, just trying to make it easier to find.

Reviewed-by: Alina Buzachis <None>
tremble added a commit to tremble/amazon.aws that referenced this pull request May 19, 2022
…ion requirements in line with collection requirements (ansible-collections#819)

Update plugin docs to explicitly list python, boto3 and botocore version requirements

SUMMARY
Update plugin docs to explicitly list python, boto3 and botocore version requirements in line with collection requirements.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
plugins/inventory/aws_ec2.py
plugins/inventory/aws_rds.py
plugins/lookup/aws_account_attribute.py
plugins/lookup/aws_secret.py
plugins/lookup/aws_ssm.py
ADDITIONAL INFORMATION
This is in line with the collection requirements, just trying to make it easier to find.

Reviewed-by: Alina Buzachis <None>
softwarefactory-project-zuul bot pushed a commit that referenced this pull request May 19, 2022
…ion requirements in line with collection requirements (#819) (#822)

[stable-2] Update plugin docs to explicitly list python, boto3 and botocore version

Manual backport of #819
SUMMARY
Update plugin docs to explicitly list python, boto3 and botocore version requirements in line with collection requirements.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
plugins/inventory/aws_ec2.py
plugins/inventory/aws_rds.py
plugins/lookup/aws_account_attribute.py
plugins/lookup/aws_secret.py
plugins/lookup/aws_ssm.py
ADDITIONAL INFORMATION
This is in line with the collection requirements, just trying to make it easier to find.

Reviewed-by: Alina Buzachis <None>
@tremble tremble deleted the plugin/boto3/docs branch September 9, 2022 08:52
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
wafv2_web_acl: more examples

SUMMARY
Closes: ansible-collections#819

More examples
Ref to official documentation for managed rules

ISSUE TYPE

Docs Pull Request

COMPONENT NAME

wafv2_wab_acl

Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
wafv2_web_acl: more examples

SUMMARY
Closes: ansible-collections#819

More examples
Ref to official documentation for managed rules

ISSUE TYPE

Docs Pull Request

COMPONENT NAME

wafv2_wab_acl

Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
wafv2_web_acl: more examples

SUMMARY
Closes: ansible-collections#819

More examples
Ref to official documentation for managed rules

ISSUE TYPE

Docs Pull Request

COMPONENT NAME

wafv2_wab_acl

Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-2 PR should be backported to the stable-2 branch backport-3 PR should be backported to the stable-3 branch community_review docs inventory inventory plugin lookup lookup plugin mergeit Merge the PR (SoftwareFactory) needs_triage new_plugin New plugin plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants